[dm-devel] [Patch] log an error if the target is an unknown type

Joe Thornber thornber at redhat.com
Mon Mar 15 15:55:01 UTC 2004


Log an error if the target has unknown target type, or zero length.
--- diff/drivers/md/dm-table.c	2004-03-15 14:24:17.836787144 +0000
+++ source/drivers/md/dm-table.c	2004-03-15 15:48:51.614455696 +0000
@@ -663,12 +663,14 @@ int dm_table_add_target(struct dm_table 
 
 	if (!len) {
 		tgt->error = "zero-length target";
+		DMERR(": %s\n", tgt->error);
 		return -EINVAL;
 	}
 
 	tgt->type = dm_get_target_type(type);
 	if (!tgt->type) {
 		tgt->error = "unknown target type";
+		DMERR(": %s\n", tgt->error);
 		return -EINVAL;
 	}
 
@@ -705,7 +707,7 @@ int dm_table_add_target(struct dm_table 
 	return 0;
 
  bad:
-	printk(KERN_ERR DM_NAME ": %s\n", tgt->error);
+	DMERR(": %s\n", tgt->error);
 	dm_put_target_type(tgt->type);
 	return r;
 }



More information about the dm-devel mailing list