[dm-devel] pgcmp code nit

Benjamin Marzinski bmarzins at redhat.com
Wed Jul 13 19:17:40 UTC 2005


I was looking at the pgcmp code, and I noticed that there's a chance that
it will say that two maps equal when they are not.

For instance if you had a path group with 2 paths that had the addresses
0x10F0F0 and 0x100F00, and another path group with 2 paths that had the
addresses 0x100000 and 0x10FFF0, these two path groups would have the same
id. It seems to me that this could, if you were really unlucky, cause
multipath to not reload, even if there had been a topology change. Of course,
this isn't really likely, and rerunning multipath would probably fix it,
but it's still there.

Of course, I might be missing something that would keep this from happening.

-Ben




More information about the dm-devel mailing list