[dm-devel] [PATCH and question]: dm-table should check for valid queue

Stefan Bader Stefan.Bader at de.ibm.com
Thu Aug 10 11:29:08 UTC 2006


Hi,

in some cases it is possible that bdev_get_queue() returns NULL. And
there are some places where device-mapper just uses the returned pointer
to call queue functions. The attached patch adds this to
dm_table_unplug_all() and dm_table_flush_all(). I treated a device
without a queue as sort of successfully flushed. Is this what would be
expected?
Same problem with dm_table_any_congested() which I didn't change, yet.
This function should probably also check before using
q->backing_dev_info. But what effect should a missing queue have? Same
as device is congested or not or let the call fail somehow?

Regards,
Stefan Bader
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dm-table-checkreqq.diff
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20060810/b782544a/attachment.ksh>


More information about the dm-devel mailing list