[dm-devel] dm snapshot: fix freeing pending exception

Milan Broz mbroz at redhat.com
Tue Dec 5 15:11:18 UTC 2006


Fix oops when removing full snapshot
kernel bugzilla bug 7040

If a snapshot became invalid (full) while there is outstanding 
pending_exception, pending_complete() forgets to remove
the corresponding exception from its exception table before freeing it.

Already fixed in 2.6.19.

Signed-off-by: Milan Broz <mbroz at redhat.com>
Signed-off-by: Chris Wright <chrisw at sous-sol.org>
---
 drivers/md/dm-snap.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.18.5.orig/drivers/md/dm-snap.c
+++ linux-2.6.18.5/drivers/md/dm-snap.c
@@ -691,6 +691,7 @@ static void pending_complete(struct pend
 
 		free_exception(e);
 
+		remove_exception(&pe->e);
 		error_snapshot_bios(pe);
 		goto out;
 	}


Patches currently in stable-queue which might be from mbroz at redhat.com are

queue-2.6.18/dm-snapshot-fix-freeing-pending-exception.patch




More information about the dm-devel mailing list