[dm-devel] Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes

[Darrick J. Wong]

Looks good and tests ok, with one issue: I still have a preference for
returning -ENOTTY over 0/0/0 when dm doesn't know the geometry.  That
said, most programs will see the zero cylinder count and make a guess,
so it probably doesn't matter.

If you're happy with it, I say put it in.  Thanks for the cleanup, by
the way!

--Darrick

On Wed, 2006-02-22 at 22:32 +0000, Alasdair G Kergon wrote:
> On Fri, Feb 17, 2006 at 04:59:58PM -0800, Darrick J. Wong wrote:
> > Here's the third revision, with the geometry pushed into mapped_device 
> > as well as fixes for the problems that you pointed out wrt string 
> > passing, lack of warning messages, etc.  Thanks for all the great feedback!
>  
> Almost there now: how does the version below look?
> Corresponding userspace changes are in device-mapper CVS.
> 
> Alasdair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20060222/2553179e/attachment.sig>