[dm-devel] [patch 08/24] dm: multipath: fix rr_add_path order

akpm at osdl.org akpm at osdl.org
Thu Nov 9 01:44:43 UTC 2006


From: Jonathan E Brassow <jbrassow at redhat.com>

When adding paths to the round-robin path selector, their order gets inverted,
which is not desirable.

Fix by replacing list_add() with list_add_tail().

Signed-off-by: Jonathan E Brassow <jbrassow at redhat.com>
Signed-off-by: Alasdair G Kergon <agk at redhat.com>
Cc: <dm-devel at redhat.com>
Signed-off-by: Andrew Morton <akpm at osdl.org>
---

 drivers/md/dm-round-robin.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/md/dm-round-robin.c~dm-multipath-fix-rr_add_path-order drivers/md/dm-round-robin.c
--- a/drivers/md/dm-round-robin.c~dm-multipath-fix-rr_add_path-order
+++ a/drivers/md/dm-round-robin.c
@@ -136,7 +136,7 @@ static int rr_add_path(struct path_selec
 
 	path->pscontext = pi;
 
-	list_add(&pi->list, &s->valid_paths);
+	list_add_tail(&pi->list, &s->valid_paths);
 
 	return 0;
 }
_




More information about the dm-devel mailing list