[dm-devel] Re: [PATCH 1/1] Resend RTPG command if buffer short

[Christophe Varoqui]

Le mardi 14 novembre 2006 à 19:04 -0500, Brian Geisel a écrit :
> Hi Christophe,
> 
> The following patch adds error and size checking to the REPORT TARGET
> PORT GROUPS command issued by rtpg.c.  The old code issued a buffer of
> 128 bytes, but never checked the return length.  The new code starts
> with a buffer of 128 bytes, but reallocates it if the buffer is too
> small (SCSI returns the necessary length in the response data).  This is
> more robust as it handles devices that consume more than 128 bytes for
> RTPG, like the Incipient NSP.
> 
> I tried to handle errors, etc. as closely as I could to what is already
> there in the code.  Let me know if you'd prefer anything written
> differently.
> 
I merged a slightly modified version.
Please report about possible regressions.

Thanks,
cvaroqui
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-alua-adjust-buffer-size.diff
Type: text/x-patch
Size: 1527 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20061116/a68b4b05/attachment.bin>