[dm-devel] Wrong entries in hwtable.c for Hitachi Storage in device-mapper-multipath-0.4.5-16.1.RHEL4.src.rpm

[Matthias Rudolph]

Hi all,

I checked the latest dm-multipath in RHEL4U4 with Hitachi Storage
Arrays. Normally it should work now without a modified or created
/etc/multipath.conf. But it does not. I beliefe the file hwtable.c of
the source is not correct. The right entries on kernel.org did not found
the way to the RedHat package. Here my suggestions for file hwtable.c:

Wrong lines (please delete):
	r += store_hwe_ext(hw, "HP", "OPEN-.", MULTIBUS, DEFAULT_GETUID,
NULL,
		"0", "0", "tur", FAILBACK_UNDEF, NULL);
	r += store_hwe(hw, "HITACHI", "DF400", MULTIBUS,
DEFAULT_GETUID);
	r += store_hwe(hw, "HITACHI", "DF500", MULTIBUS,
DEFAULT_GETUID);
	r += store_hwe(hw, "HITACHI", "DF600", MULTIBUS,
DEFAULT_GETUID);
	r += store_hwe_ext(hw, "HITACHI", "DF600F*", GROUP_BY_PRIO,
		DEFAULT_GETUID, "/sbin/mpath/prio_hds_modular %d", "0",
"0",
 		"readsector0", -FAILBACK_IMMEDIATE, NULL);

Correct lines (please add):
	r += store_hwe_ext(hw, "{HITACHI,HP}", "OPEN-.*", MULTIBUS,
		DEFAULT_GETUID, NULL, "0", "0", "readsector0",
FAILBACK_UNDEF,
		NULL);
	r += store_hwe_ext(hw, "HITACHI", "DF.*", GROUP_BY_PRIO,
		DEFAULT_GETUID, "/sbin/mpath_prio_hds_modular %d", "0",
"0",
		"readsector0", -FAILBACK_IMMEDIATE, NULL);

I hope the regular expressions are correct for dm-multipath.
The file multipath.conf.defaults does also not match the entries in file
hwtable.c.

A temporary fix for the problem above is to create the file
/etc/multipath.conf with the entries below:

devices {
	device {
		vendor                  "HITACHI"
		product                 "DF.*"
		path_grouping_policy    group_by_prio
		prio_callout            "/sbin/pp_hds_modular %d"
		path_checker            readsector0
		getuid_callout          "/sbin/scsi_id -g -u -s
/block/%n"
		failback                immediate
		}
	device {
		vendor                  "HITACHI"
		product                 "OPEN-.*"
		path_grouping_policy    multibus
		path_checker            readsector0
		getuid_callout          "/sbin/scsi_id -g -u -s
/block/%n"
		}
	}


Regards
Matthias Rudolph