[dm-devel] Re: [PATCH] block: factor out bio_check_eod()

Jens Axboe jens.axboe at oracle.com
Wed Jul 18 11:31:03 UTC 2007


On Wed, Jul 18 2007, Tejun Heo wrote:
> Jens Axboe wrote:
> > On Wed, Jul 18 2007, Tejun Heo wrote:
> >> End of device check is done twice in __generic_make_request() and it's
> >> fully inlined each time.  Factor out bio_check_eod().
> > 
> > Tejun, yeah I should seperate the cleanups and put them in the upstream
> > branch. Will do so and add your signed-off to both of them.
> > 
> 
> Would they be different from the one I just posted?  No big deal either
> way.  I'm just basing the zero-length barrier on top of these patches.
> Oh well, the changes are trivial anyway.

This one ended up being the same, but in the first one you missed some
of the cleanups. I ended up splitting the patch some more though, see
the series:

http://git.kernel.dk/?p=linux-2.6-block.git;a=shortlog;h=barrier

-- 
Jens Axboe




More information about the dm-devel mailing list