[dm-devel] Re: [PATCH 0/3] Changes to Userspace multipath code to support lsi-rdac

Christophe Varoqui christophe.varoqui at free.fr
Wed Mar 21 23:06:55 UTC 2007


Le mercredi 21 mars 2007 à 11:38 -0800, Chandra Seetharaman a écrit :
> Hi All,
> 
> While working on lsi-rdac hardware handler, I found that the checkers "tur"
> and "readsector0" are not serving the lsi-rdac properly. Also, the storage
> device has a active/passive state which need to be handled properly.
> 
> So, I wrote a new path checker for lsi-rdac, to use the C4 inquiry page to get
> the current owner of the lun and set the state as UP(active) or GHOST(passive).
> Changes are in patch 1/3.
> 
> After applying the above patch, I realized the priorities are not set properly.
> Made some changes to use the GHOST state while setting priorities. Changes are
> in patch 2/3.
> 
> Debugging the above patches found that the wait time (5 seconds) in multipathd
> was not sufficient for the devices to appear in /dev/ It was taking about 20
> seconds. Changed the wait time to be 60 seconds. Change in patch 3/3.
> 
> Please provide me with your feedback/comment on these changes regarding
> correctness, completeness etc.,
> 
Looks very good. I merged the 3 patches.

In 1/3, I changed the DEF_TIMEOUT name to avoid surcharging the one in
checker.h

I'm having a hard time push to kernel.org, so don't expect to see the
git tree updated soon.

Thanks,
cvaroqui




More information about the dm-devel mailing list