[dm-devel] [PATCH] Fixup varags usage

Hannes Reinecke hare at suse.de
Wed Apr 30 09:03:34 UTC 2008


We already call va_end() at the correct position, no need to
duplicate it in log_safe().

Signed-off-by: Hannes Reinecke <hare at suse.de>
---
 libmultipath/log_pthread.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/libmultipath/log_pthread.c b/libmultipath/log_pthread.c
index 8976bfb..8909440 100644
--- a/libmultipath/log_pthread.c
+++ b/libmultipath/log_pthread.c
@@ -15,9 +15,7 @@
 void log_safe (int prio, const char * fmt, va_list ap)
 {
 	pthread_mutex_lock(logq_lock);
-	//va_start(ap, fmt);
 	log_enqueue(prio, fmt, ap);
-	va_end(ap);
 	pthread_mutex_unlock(logq_lock);
 
 	pthread_mutex_lock(logev_lock);
-- 
1.5.2.4




More information about the dm-devel mailing list