[dm-devel] multipath -f/-F exit status
Christophe Varoqui
christophe.varoqui at free.fr
Sat Dec 13 11:59:37 UTC 2008
> Hi Folks,
>
> Older versions of multipath-tools would always exit with status 0
> (success) when flushing multipath device maps (-f/-F). This was never
> guaranteed but happened because the "r" local in multipath/main.c was
> used uninitialised in these code paths (by chance, it always lands on
> a freshly zeroed stack page, so although undefined the behaviour was
> pretty reliable).
>
> This was changed by commit 8497928514aa3df6d46f24d8d9b70b086e9fcfbd:
>
Then by a9a6c71592d4e2271a38c3d334bee7cbce963cff.
Does the upstream version works as you expect in this regard ?
> multipath -F
> ------------
>
> -F flush all unused multipath device maps
>
> Exit status
> 0 At least one unused multipath device map was flushed
> 1 No unused maps were found or no maps could be flushed
>
> The alternative for -F seems to be to return 0 if all unused maps were
> flushed and 1 if there were unused maps that could not be flushed.
> This doesn't seem like a very likely occurrence, but maybe it should
> be handled separately?
>
I guess the current implementation return r as the number failures.
Regards,
cvaroqui
More information about the dm-devel
mailing list