[dm-devel] Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related?

Ingo Molnar mingo at elte.hu
Tue Feb 26 11:29:32 UTC 2008


* Jiri Kosina <jkosina at suse.cz> wrote:

> +	name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> +	fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> +
> +	if (!name || !fname) {
> +		*err = -ENOMEM;
> +		return NULL;
> +	}
> +
>  	if (dentry) {
>  		if (!dentry->d_name.len) {
>  			*err = -EINVAL;

this bit is missing i think:

	if (name)
		kfree(name);
	if (fname)
		kfree(fname);

	Ingo




More information about the dm-devel mailing list