[dm-devel] Re: [PATCH 4/7] scsi_dh: Update EMC handler

[Hannes Reinecke]

Hi Chandra,

Chandra Seetharaman wrote:
> On Wed, 2008-05-14 at 16:43 +0200, Hannes Reinecke wrote:
> <snip>
> 
>> @@ -438,10 +604,32 @@ static int clariion_bus_attach(struct scsi_device *sdev)
>>  	sdev->scsi_dh_data = scsi_dh_data;
>>  	spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
>>
> Can move the block above to be just before try_module_get() and avoid
> undoing it in the failed path.
> 
Hmm. Yes, we could. But that means I have to pass the scsi_dh_data structure
to basically every function.
Let me check how this pans out.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare at suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)