[dm-devel] Re: [PATCH] Fix Null pointer Exception

[Alasdair G Kergon]

On Wed, Sep 24, 2008 at 03:17:37PM +0200, Stefan Raspl wrote:
> Alasdair G Kergon wrote:
> > Have you had chance to look at old kernel versions to see in which
> > commit this was introduced?
> The next best thing I can come up with is that it has been around in
> 2.6.9 already. But I believe the DASD driver did the NULL thing to
> its internal queue also back then, still.
 
Well, in the absence of further information and being unaware of any
other driver doing this, rather than changing several places in the
block layer to cope with one out-of-the-ordinary driver, I wish to see
the driver fixed to work within the existing block layer design.  If
that is difficult or impossible (which I doubt), then we need more
information to justify that position.

Meanwhile I will not be applying that patch, though I may take a patch
to provide clean diagnostics should a situation like this occur again.

Alasdair
-- 
agk at redhat.com