[dm-devel] Re: [PATCH v2] dm table: verify each table mapping is HW sector aligned

Mike Snitzer snitzer at redhat.com
Mon Apr 13 16:02:21 UTC 2009


On Fri, Apr 10 2009 at 12:31am -0400,
Mike Snitzer <snitzer at redhat.com> wrote:

> On Thu, Apr 09 2009 at 11:58pm -0400,
> Mike Snitzer <snitzer at redhat.com> wrote:
> 
> > Each mapping in a DM table must be properly aligned on HW sector
> > boundaries.  This is particularly important when a DM table is composed
> > of mappings for devices with different HW sector sizes.
> > 
> > Signed-off-by: Mike Snitzer <snitzer at redhat.com>
> > ---
> >  drivers/md/dm-table.c |  112 +++++++++++++++++++++++++++++++++++++++++++------
> >  1 files changed, 99 insertions(+), 13 deletions(-)
> 
> This patch applies cleanly, but with fuzz, to the most recent linux-2.6
> (as of this writing: 62b8e680e).

But I just noticed a flaw in the 'remaining_sectors' calculation (when
the target's len is less than the overall table's H/W sector size).
I'll be posting a new patch (v3) shortly.

Mike




More information about the dm-devel mailing list