[dm-devel] Re: [PATCH] Drop 80-character limit in checkpatch.pl

[Valdis.Kletnieks at vt.edu]

On Thu, 17 Dec 2009 18:29:25 EST, Mikulas Patocka said:

> There is no need to make a script for it. The script isn't so smart to 
> tell what is understandable and what is nto.

Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non-
continuation line, it's probably in its rights to whinge. 

grep -r -P '^\t{7}(?!(.*,$|.*\);$))' . | more

produces a whole lot of "this can't end well" output. My favorite so far:

fs/reisersfs/do_balan.c, lines 460-477 (note: 3 leading tabs elided)

				leaf_paste_entries(&bi,
						   n +
						   item_pos
						   -
						   ret_val,
						   l_pos_in_item,
						   1,
						   (struct
						    reiserfs_de_head
						    *)
						   body,
						   body
						   +
						   DEH_SIZE,
						   tb->
						   insert_size
						   [0]
				    );

Yes, that used to be 24 more columns to the right.  Gaak.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20091217/f328fac9/attachment.sig>