[dm-devel] Re: [2.6.29 PATCH 01/02] dm target: use module refcount directly

[Cheng Renquan]

On Thu, Jan 8, 2009 at 4:41 AM, Alasdair G Kergon <agk at redhat.com> wrote:
> From: Cheng Renquan <crquan at gmail.com>
>
> The tt_internal's 'use' field is superfluous: the module's refcount can do
> the work properly.  An acceptable side-effect is that this increases the
> reference counts reported by 'lsmod'.
>
> Remove the superfluous test when removing a target module.

Thank you for doing the work, I'm just too busy to have time to take it.

I've applied these two patches on the current linus's 2.6.29 kernel
head, and have done some simple building and running tests, it seems
OK with allyesconfig, allnoconfig(with all DM config enabled), and
serverl randconfigs with DM enabled.

> Signed-off-by: Cheng Renquan <crquan at gmail.com>
> Reviewed-by: Alasdair G Kergon <agk at redhat.com>
> Signed-off-by: Alasdair G Kergon <agk at redhat.com>
> ---
>  drivers/md/dm-target.c |   20 +++-----------------
>  1 files changed, 3 insertions(+), 17 deletions(-)
>
> Index: linux-2.6.28/drivers/md/dm-target.c
> ===================================================================
> --- linux-2.6.28.orig/drivers/md/dm-target.c    2009-01-07 20:29:57.000000000 +0000
> +++ linux-2.6.28/drivers/md/dm-target.c 2009-01-07 20:30:57.000000000 +0000

-- 
Cheng Renquan (程任全), Shenzhen, China
Joan Crawford  - "I, Joan Crawford, I believe in the dollar.
Everything I earn, I spend."