[dm-devel] Re: [PATCH 2/3] scsi_dh: Provide set_params interface in emc device handler

[Eddie Williams]

On Wed, 2009-07-01 at 20:13 -0700, Chandra Seetharaman wrote:
> Handle the parameters provided by user thru multipath.
> 
> This handler expects only 2 parameters and their value can either be 0 or 1.
> 
> This code originates from the old dm-emc.c file. Appropriate changes have
> been made to make it work in the new design.
> 
> Signed-off-by: Chandra Seetharaman <sekharan at us.ibm.com>
> ---
>  drivers/scsi/device_handler/scsi_dh_emc.c |   56 ++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
> 
> Index: linux-2.6.31-rc1/drivers/scsi/device_handler/scsi_dh_emc.c
> ===================================================================
> --- linux-2.6.31-rc1.orig/drivers/scsi/device_handler/scsi_dh_emc.c
> +++ linux-2.6.31-rc1/drivers/scsi/device_handler/scsi_dh_emc.c
> @@ -561,6 +561,61 @@ done:
>  
>  	return result;
>  }
> +/*
> + * params - parameters in the following format
> + *      "no_of_params\0param1\0param2\0param3\0...\0"
> + *      for example, string for 2 parameters with value 10 and 21
> + *      is specified as "2\010\021\0".
> + */
> +static int clariion_set_params(struct scsi_device *sdev, const char *params)
> +{
> +	struct clariion_dh_data *csdev = get_clariion_data(sdev);
> +	unsigned int hr = 0, st = 0, argc;
> +	char *p = params;

This throws a compiler warning resolved with a type cast:
	char *p = (char *)params;