[dm-devel] Re: [PATCH block#for-2.6.31] block: add request clone interface (v2)

[Boaz Harrosh]

On 06/16/2009 06:02 AM, Kiyoshi Ueda wrote:
> Hi Boaz, Jeff, Jens,
>>> Perhaps
>>> blk_rq_{clone,declone} or blk_rq_{clone,declone}_bios
>>>
>>> (Both unclone and declone are found on the net but are not
>>>  found in the free dictionary)
> 
> I had a feeling that blk_rq_{clone,declone} allocates/frees
> the clone request inside the interfaces like bio_clone(), so
> I didn't take such namings.
> And, the clone setup interface may not only make bio clones
> but also do something else (for other request members), so
> I didn't add any 'bio' namings to the interfaces.
> 

I'm convinced blk_rq_prep_clone is good for what it actually does

> Jens, what do you prefer?
> 
> Thanks,
> Kiyoshi Ueda

Thanks
Boaz