[dm-devel] [PATCH] dm snapshot: use unsigned integer chunk size

Alasdair G Kergon agk at redhat.com
Fri Oct 2 22:27:16 UTC 2009


On Wed, Sep 30, 2009 at 10:41:10AM -0400, Mike Snitzer wrote:
> Maximum chunk size is 512kB, 

Can you confirm that a supplied chunk size of 4294971392, for example, still
gets rejected?

> Signed-off-by: Mikulas Patocka <mpatocka at redhat.com>
> Signed-off-by: Mike Snitzer <snitzer at redhat.com>
> Reviewed-by: Jonathan Brassow <jbrassow at redhat.com>

> -	unsigned long chunk_size_ulong;
> +	unsigned chunk_size;

> -	chunk_size_ulong = simple_strtoul(chunk_size_arg, &value, 10);
> +	chunk_size = simple_strtoul(chunk_size_arg, &value, 10);

Alasdair




More information about the dm-devel mailing list