[dm-devel] [PATCH] dm-sysfs: Add empty release function to avoid debug warning.

Milan Broz mbroz at redhat.com
Tue Oct 20 13:07:04 UTC 2009


The kobject is embedded in mapped device struct, so
code do not need to release memory explicitly here.

This patch just removes annoying warning:
 kobject: 'dm': does not have a release() function,
 it is broken and must be fixed.

Signed-off-by: Milan Broz <mbroz at redhat.com>
---
 drivers/md/dm-sysfs.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/md/dm-sysfs.c b/drivers/md/dm-sysfs.c
index 4b04590..b000de3 100644
--- a/drivers/md/dm-sysfs.c
+++ b/drivers/md/dm-sysfs.c
@@ -80,12 +80,20 @@ static struct sysfs_ops dm_sysfs_ops = {
 };
 
 /*
+ * The sysfs structure is embedded in md struct, nothing to do here
+ */
+static void dm_sysfs_release(struct kobject *kobj)
+{
+}
+
+/*
  * dm kobject is embedded in mapped_device structure
  * no need to define release function here
  */
 static struct kobj_type dm_ktype = {
 	.sysfs_ops	= &dm_sysfs_ops,
 	.default_attrs	= dm_attrs,
+	.release	= dm_sysfs_release
 };
 
 /*
-- 
1.6.5




More information about the dm-devel mailing list