[dm-devel] [PATCH 2 of 2] DM Snapshot: insert missing failure condition step
Jonathan Brassow
jbrassow at redhat.com
Tue Sep 22 21:17:31 UTC 2009
Patch name: dm-snap-insert-missing-failure-condition-step.patch
While initializing the snapshot module, if we fail to register
the snapshot target then we must back-out the exception store
module initialization.
Signed-off-by: Jonathan Brassow <jbrassow at redhat.com>
Reviewed-by: Mikulas Patocka <mpatocka at redhat.com>
Reviewed-by: Mike Snitzer <snitzer at redhat.com>
Index: linux-2.6/drivers/md/dm-snap.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-snap.c
+++ linux-2.6/drivers/md/dm-snap.c
@@ -1465,7 +1465,7 @@ static int __init dm_snapshot_init(void)
r = dm_register_target(&snapshot_target);
if (r) {
DMERR("snapshot target register failed %d", r);
- return r;
+ goto bad_register_target;
}
r = dm_register_target(&origin_target);
@@ -1522,6 +1522,9 @@ bad2:
dm_unregister_target(&origin_target);
bad1:
dm_unregister_target(&snapshot_target);
+
+bad_register_target:
+ dm_exception_store_exit();
return r;
}
More information about the dm-devel
mailing list