[dm-devel] [PATCH] Just inform and dont warn when DM_DEV_REMOVE is tried on a open device

Nikanth Karthikesan knikanth at suse.de
Tue Apr 20 07:16:58 UTC 2010


Dont warn when DM_DEV_REMOVE ioctl is tried on a open device.

On openSUSE when cryptsetup and udev interact, cryptsetup sometimes tries to
remove a dm device currently opened by blkid, which is not a serious issue to
print a kernel warning. The application should retry if -EBUSY is returned. So
let us make it an informational message instead.

Signed-off-by: Nikanth Karthikesan <knikanth at suse.de>

---

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index d7500e1..dcfa48a 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -729,7 +729,7 @@ static int dev_remove(struct dm_ioctl *param, size_t param_size)
 	 */
 	r = dm_lock_for_deletion(md);
 	if (r) {
-		DMWARN("unable to remove open device %s", hc->name);
+		DMINFO("unable to remove open device %s", hc->name);
 		up_write(&_hash_lock);
 		dm_put(md);
 		return r;




More information about the dm-devel mailing list