[dm-devel] [PATCH v2] dm: Fix alignment stacking on partitioned devices
Martin K. Petersen
martin.petersen at oracle.com
Wed Jan 6 03:24:59 UTC 2010
>>>>> "Mike" == Mike Snitzer <snitzer at redhat.com> writes:
Mike,
Mike> After looking closer there seems to be various type
Mike> inconsistencies in the alignment_offset and discard_alignment
Mike> related routines (returning 'int' in places, etc).
Mike> The following patch is what I found; I have no problem with
Mike> switching from 'unsigned long' to blk_off_t for LBD though.
I only use blk_off_t in the places where we're dealing with absolute
offsets.
Blindly converting alignment_offset from int to unsigned long won't
work. We depend on being able to return -1 in case of
misalignment. Hence int and not unsigned int. Furthermore, the returned
values are always modulo the granularity so int is plenty big.
So NAK from here.
--
Martin K. Petersen Oracle Linux Engineering
More information about the dm-devel
mailing list