[dm-devel] [PATCH]md:dm.c Fix warning: statement with no effect

Alasdair G Kergon agk at redhat.com
Sat Jul 31 19:07:57 UTC 2010


On Sat, Jul 31, 2010 at 12:05:04PM -0700, Justin P. Mattock wrote:
> haven't heard any feedback on this any ideas?
>> Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below)
>>    CC      drivers/md/dm.o
>> drivers/md/dm.c: In function 'split_bvec':
>> drivers/md/dm.c:1117:3: warning: statement with no effect
>> drivers/md/dm.c: In function 'clone_bio':
>> drivers/md/dm.c:1145:3: warning: statement with no effect

I'd suggest hiding it inside the .h files and not trying to scatter #ifdefs 
throughout the code.

Alasdair




More information about the dm-devel mailing list