[dm-devel] [PATCH 1/3] Send KOBJ_ADD event after dm resume ioctl.

Milan Broz mbroz at redhat.com
Fri Mar 19 11:14:24 UTC 2010


On 03/19/2010 11:16 AM, Kay Sievers wrote:

> There are several subsystems that depend on updating everything with
> "change" events when device configurations change. There is nothing
> inherently wrong with this approach, as long as subsystems send the
> proper "change" events and don't try to hide anything they have
> registered.

ok, this is perfectly fine with dm devices, CHANGE announces all
changes. Just I am not sure if all consumers of events (and separate
rules authors) know about that, I saw so many problems with
failing something when wrongly reacting to ADD event...

Also it means that after ADD the by-uuid* and similar symlinks
cannot be yet trusted - if the UUID is read from device and device
is not yet ready.

Well. And what should happen if anyone generate
artificial CHANGE event before the real first CHANGE event comes from
subsystem? (yes, I am looking at you, OPTIONS+="watch" thing for example)

According to above, rules must be written such way that every ADD/CHANGE
event must expect that device is not ready, so it can create only
partial info in udev, is it correct?
(this is of course no problem if the rules are the same for both cases)

Milan
--
mbroz at redhat.com




More information about the dm-devel mailing list