[dm-devel] [PATCH] dm-log-userspace: Failure to trap all errors
Jonathan Brassow
jbrassow at redhat.com
Fri Mar 19 22:04:37 UTC 2010
This patch resolves unhandled errors.
When constructing a mirror, it is possible for the initial request to
fail for other reasons besides just -ESRCH. These must be handled too.
Signed-off-by: Jonathan Brassow <jbrassow at redhat.com>
Index: linux-2.6/drivers/md/dm-log-userspace-base.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-log-userspace-base.c
+++ linux-2.6/drivers/md/dm-log-userspace-base.c
@@ -180,8 +180,11 @@ static int userspace_ctr(struct dm_dirty
r = dm_consult_userspace(lc->uuid, lc->luid, DM_ULOG_CTR,
ctr_str, str_size, NULL, NULL);
- if (r == -ESRCH) {
- DMERR("Userspace log server not found");
+ if (r < 0) {
+ if (r == -ESRCH)
+ DMERR("Userspace log server not found");
+ else
+ DMERR("Userspace log server failed to create log");
goto out;
}
More information about the dm-devel
mailing list