[dm-devel] [PATCH v3 3/3] dm: lookup devices by path with name_to_dev_t
Will Drewry
wad at chromium.org
Mon May 24 14:44:07 UTC 2010
On Mon, May 24, 2010 at 6:38 AM, Alasdair G Kergon <agk at redhat.com> wrote:
> I'll apply this, [snip]
Thanks!
On Mon, May 24, 2010 at 6:57 AM, Alasdair G Kergon <agk at redhat.com> wrote:
> On Wed, May 19, 2010 at 01:38:24PM -0500, Will Drewry wrote:
>> + char base_path[32]; /* size from name_to_dev_t */
>
>> + /* stage the shorter path for name_to_dev_t. */
>> + strncpy(base_path, path, sizeof(base_path));
>
> I'm dropping that, and just passing path directly, so the strlen test
> will be used. (There's a "name += 5" in there so 32 would ignore
> any longer standard names anyway.)
Sounds good. And nice catch on the truncation with 32 - in an
attempt to minimize the extra copying, I went a bit too far!
fwiw, the only reason for the copy was because |path| is a
const in the function but not when passed to name_to_dev_t.
I wasn't sure what the preferred practice was so I just duped
the data needed.
cheers!
will
More information about the dm-devel
mailing list