[dm-devel] [PATCH 05/10] block: remove per-queue plugging
Jens Axboe
jaxboe at fusionio.com
Tue Apr 12 06:20:43 UTC 2011
On 2011-04-12 00:58, hch at infradead.org wrote:
> Looking at the patch
> (http://git.kernel.dk/?p=linux-2.6-block.git;a=commitdiff;h=761e433f3de6fb8e369af9e5c08beb86286d023f)
>
> I'm not sure it's an optimal design. The flush callback really
> is a per-queue thing. Why isn't it a function pointer in the request
> queue when doing the blk_run_queue call once we're done with a given
> queue before moving on to the next one?
I was thinking about this yesterday as well, the design didn't quite
feel just right. Additionally the user now must track this state too,
and whether he's plugged on that task or not.
I'll rewrite this.
--
Jens Axboe
More information about the dm-devel
mailing list