[dm-devel] [patch] md/dm-log: use PTR_ERR value instead of -ENOMEM

[Jonathan Brassow]

ACK

  brassow

On May 16, 2010, at 1:31 AM, Dan Carpenter wrote:

> It's nicer to return the PTR_ERR() value instead of just returning
> -ENOMEM.  In the current code the PTR_ERR() value is always equal to
> -ENOMEM so this doesn't actually affect anything, but still...
>
> Signed-off-by: Dan Carpenter <error27 at gmail.com>
>
> diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
> index 5a08be0..fbd80fb 100644
> --- a/drivers/md/dm-log.c
> +++ b/drivers/md/dm-log.c
> @@ -455,7 +455,7 @@ static int create_log_context(struct  
> dm_dirty_log *log, struct dm_target *ti,
> 			r = PTR_ERR(lc->io_req.client);
> 			DMWARN("couldn't allocate disk io client");
> 			kfree(lc);
> -			return -ENOMEM;
> +			return r;
> 		}
>
> 		lc->disk_header = vmalloc(buf_size);
>
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel