[dm-devel] [PATCH] dm mpath: fix potential NULL pointer in feature arg processing
Mike Snitzer
snitzer at redhat.com
Tue Jun 28 20:12:50 UTC 2011
If a user specifies an mpath target as having 1 or more features but
doesn't specify the corresponding feature args a NULL pointer occurs
in parse_features() -- @param_name is NULL when passed to strnicmp().
Signed-off-by: Mike Snitzer <snitzer at redhat.com>
Cc: stable at kernel.org
---
drivers/md/dm-mpath.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index aa4e570..209991b 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -807,6 +807,11 @@ static int parse_features(struct arg_set *as, struct multipath *m)
if (!argc)
return 0;
+ if (argc > as->argc) {
+ ti->error = "not enough arguments for features";
+ return -EINVAL;
+ }
+
do {
param_name = shift(as);
argc--;
--
1.7.4.4
More information about the dm-devel
mailing list