[dm-devel] [PATCH] scsi_dh_alua: Fix the time inteval for alua rtpg commands

Moger, Babu Babu.Moger at netapp.com
Thu Oct 27 18:36:32 UTC 2011


This patch corrects the retry interval for alua rtpg command. Purpose was to retry the commands in seconds.
But that was not happening. Reason is msleep takes argument in milliseconds.

Also added minor text after successful attach. 

Signed-off-by: Babu Moger <babu.moger at netapp.com>
CC: Hannes Reinecke <hare at suse.de> 
---

--- linux-3.1-rc4/drivers/scsi/device_handler/scsi_dh_alua.c.orig	2011-10-26 11:36:11.000000000 -0500
+++ linux-3.1-rc4/drivers/scsi/device_handler/scsi_dh_alua.c	2011-10-27 12:50:41.000000000 -0500
@@ -507,7 +507,7 @@ static int alua_rtpg(struct scsi_device 
 	int len, k, off, valid_states = 0;
 	unsigned char *ucp;
 	unsigned err;
-	unsigned long expiry, interval = 1;
+	unsigned long expiry, interval = 1000;
 
 	expiry = round_jiffies_up(jiffies + ALUA_FAILOVER_TIMEOUT);
  retry:
@@ -734,6 +734,7 @@ static int alua_bus_attach(struct scsi_d
 	spin_lock_irqsave(sdev->request_queue->queue_lock, flags);
 	sdev->scsi_dh_data = scsi_dh_data;
 	spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
+	sdev_printk(KERN_NOTICE, sdev, "%s: Attached\n", ALUA_DH_NAME);
 
 	return 0;
 






More information about the dm-devel mailing list