[dm-devel] [PATCH] block: add missing block_bio_complete() tracepoint

Tejun Heo tj at kernel.org
Sun Jan 29 19:24:47 UTC 2012


On Sun, Jan 29, 2012 at 06:41:33PM +0900, Namhyung Kim wrote:
> The block_bio_complete() TP has been missed so long, so that bio-based
> drivers haven't been able to trace its IO behavior. Add it.
> 
> In some rare cases, such as loop_switch, @bio->bi_bdev can be NULL.
> Thus convert it to TRACE_EVENT_CONDITION() as Steven suggested.
> 
> From now on, request-based drivers will also get BLK_TA_COMPLETEs for
> all bio's in requests. This needs to be handled in userland properly.
> 
> Also remove external use of the TP in DM and unexport it.
> 
> Signed-off-by: Namhyung Kim <namhyung at gmail.com>
> Cc: Tejun Heo <tj at kernel.org>
> Cc: Steven Rostedt <rostedt at goodmis.org>
> Cc: dm-devel at redhat.com

I like the smiplicity change but do we know how we can filter this out
from userland?  Also, what's the reason not to do it from blktrace.c?
What would be the downside of doing that?

Thanks.

-- 
tejun




More information about the dm-devel mailing list