[dm-devel] [PATCH 06/13] block: Add bio_reset()
Tejun Heo
tj at kernel.org
Fri May 18 16:16:08 UTC 2012
Hello,
On Thu, May 17, 2012 at 10:59:53PM -0400, koverstreet at google.com wrote:
> From: Kent Overstreet <koverstreet at google.com>
>
> Reusing bios is something that's been highly frowned upon in the past,
> but driver code keeps doing it anyways. If it's going to happen anyways,
> we should provide a generic method.
>
> This'll help with getting rid of bi_destructor.
It would be nice to explain a bit why this helps bi_destructor
removal.
> +#define BIO_RESET_OFFSET offsetof(struct bio, bi_max_vecs)
Maybe better named BIO_RESET_BYTES? As offset tends to indicate the
start of a region.
Thanks.
--
tejun
More information about the dm-devel
mailing list