[dm-devel] [PATCH v3 01/26] block: Fix a buffer overrun in bio_integrity_split()
Martin K. Petersen
martin.petersen at oracle.com
Tue Oct 2 22:30:28 UTC 2012
>>>>> "Kent" == Kent Overstreet <koverstreet at google.com> writes:
>> > + *bp->bip1.bip_vec = bip->bip_vec[0];
>> > + *bp->bip2.bip_vec = bip->bip_vec[0];
>>
>> I think this is horrible.
Yep.
>> Why not introduce bvec pointer in bip (like bio), to cover the case
>> when bvec are not inline.
Kent> That's... exactly what the next patch in the series does.
I'm perfectly ok with a patch that introduces the pointer and fixes the
bio_pair case. As long as that's all it does.
--
Martin K. Petersen Oracle Linux Engineering
More information about the dm-devel
mailing list