[dm-devel] [PATCH -next] dm snapshot: fix error return code in snapshot_ctr()

Wei Yongjun weiyj.lk at gmail.com
Fri Apr 19 01:26:07 UTC 2013


From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>

Fix to return -ENOMEM in create slab pool error case
instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
---
 drivers/md/dm-snap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c
index eb32e35..fb3ea3c 100644
--- a/drivers/md/dm-snap.c
+++ b/drivers/md/dm-snap.c
@@ -1121,6 +1121,7 @@ static int snapshot_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 	s->pending_pool = mempool_create_slab_pool(MIN_IOS, pending_cache);
 	if (!s->pending_pool) {
 		ti->error = "Could not allocate mempool for pending exceptions";
+		r = -ENOMEM;
 		goto bad_pending_pool;
 	}
 




More information about the dm-devel mailing list