[dm-devel] [PATCH 1/1] libmultipath: fix segfault when vector is null

michaelc at cs.wisc.edu michaelc at cs.wisc.edu
Tue Jan 8 19:36:34 UTC 2013


From: Mike Christie <michaelc at cs.wisc.edu>

While performing tests that caused paths to get added
and deleted, we hit a segfault. We traced it to the
vector struct being NULL. This patch fixes the problem
by checking for a NULL vector before accessing it.

Signed-off-by: Mike Christie <michaelc at cs.wisc.edu>
---
 libmultipath/vector.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libmultipath/vector.c b/libmultipath/vector.c
index 652f118..0564224 100644
--- a/libmultipath/vector.c
+++ b/libmultipath/vector.c
@@ -94,6 +94,9 @@ find_slot(vector v, void * addr)
 {
 	int i;
 
+	if (!v)
+		return -1;
+
 	for (i = 0; i < (v->allocated / VECTOR_DEFAULT_SIZE); i++)
 		if (v->slot[i] == addr)
 			return i;
-- 
1.7.11.2




More information about the dm-devel mailing list