[dm-devel] [PATCH] Correctly ignore empty prio names
Hannes Reinecke
hare at suse.de
Fri May 10 14:48:58 UTC 2013
On 05/08/2013 06:28 PM, Benjamin Marzinski wrote:
> On Wed, May 08, 2013 at 11:13:43AM +0200, Hannes Reinecke wrote:
>> This is a partial revert of commit
>> 'Stop annoying prio_lookup warning messages',
>> as that patch would only fix the 'prio_put' case.
>> However, as the prio name might be empty even in
>> in prio_get() we should rather fix this in
>> prio_lookup() and handle both cases.
>
> My feeling was that you would want to get that warning message if you
> failed to get the prioritizer in prio_get() because the name was empty.
> With this change it will silently fail unless you have the verbosity set
> to 3, in which case you'll get a message like
>
> sdb: prio = (config file default)
>
> Which doesn't really look that much like an error.
>
Yeah, one should modify this message.
> On the other hand, if you never got a prioritizer at all, you don't want
> a warning message when you try to free it in prio_put() since that's
> only happening because there is nothing to free.
>
I'd rather have the functions to do the correct thing.
We've had tons and tons of issues with multipathing just because
no-one ever checked the function arguments.
So we should not be introducing this behaviour again.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
More information about the dm-devel
mailing list