[dm-devel] [PATCH 1/1] improve the performance of dm-log-userspace

Akira Hayakawa ruby.wktk at gmail.com
Thu Nov 21 10:26:31 UTC 2013


Hi, Dongmao

I think you are using workqueue the wrong way in two places.

1)
WQ_NON_REENTRANT is deprecated. You should remove it.
> +	if (lc->integrated_flush) {
> +		lc->dmlog_wq = alloc_workqueue("dmlogd", WQ_NON_REENTRANT | WQ_MEM_RECLAIM, 0);

2)
destory_workqueue first calls drain_workqueue which
then calls flush_workqueue. You should remove the first line of these.
> +		flush_workqueue(lc->dmlog_wq);
> +		destroy_workqueue(lc->dmlog_wq);

Akira




More information about the dm-devel mailing list