[dm-devel] [PATCH] Fix segfault when fast_io_fail_tmo is empty in config file.

[Christophe Varoqui]

Applied.
Thanks.


On Wed, Apr 30, 2014 at 10:20 AM, Jose Castillo <jcastillo at redhat.com>wrote:

> If the option "fast_io_fail_tmo" is specified in multipath.conf, without a
> value, the command 'multipathd reconfigure' segfaults.
> With the patch included here, multipathd returns "error parsing config
> file" and does not segfaults.
>
> Signed-off-by: Jose Castillo <jcastillo at redhat.com>
> ---
>  libmultipath/dict.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libmultipath/dict.c b/libmultipath/dict.c
> index 9db4725..91d9b83 100644
> --- a/libmultipath/dict.c
> +++ b/libmultipath/dict.c
> @@ -43,6 +43,9 @@ def_fast_io_fail_handler(vector strvec)
>         char * buff;
>
>         buff = set_value(strvec);
> +       if (!buff)
> +               return 1;
> +
>         if (strlen(buff) == 3 && !strcmp(buff, "off"))
>                 conf->fast_io_fail = MP_FAST_IO_FAIL_OFF;
>         else if (sscanf(buff, "%d", &conf->fast_io_fail) != 1 ||
> --
> 1.9.0
>
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20140430/259ead5a/attachment.htm>