[dm-devel] dm: check error instead of r in clone_endio

alex chen alex.chen at huawei.com
Thu Dec 18 01:41:03 UTC 2014


On 2014/12/18 1:34, Mike Snitzer wrote:
> On Wed, Dec 17 2014 at  1:37am -0500,
> alex chen <alex.chen at huawei.com> wrote:
> 
>> In the clone_endio, when target_type is linear and WRITE SAME bio
>> fails, r will be always be initialized 0 because of null end_io, and
>> in this case WRITE SAME will not be disabled.
>> So we should check error instead of r.
>>
>> Signed-off-by: Alex Chen <alex.chen at huawei.com>
> 
> I've fixed it a bit differently (clone_endio now matches dm_done) and
> have staged it for 3.19, see:
> https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=5164bece1673cdf04782f8ed3fba70743700f5da
> 
> Thanks.

OK, thank you!
> 
> 




More information about the dm-devel mailing list