[dm-devel] [PATCH] dm-raid: check events in super_validate

[Brassow Jonathan]

On Feb 25, 2014, at 4:22 PM, Nate Dailey wrote:

> Here's what I've done to reproduce this:
> 
> - remove a disk containing one leg of an LVM raid1 mirror
> - do enough IO that a lengthy recovery will be required
> - insert the removed disk
> - let recovery begin, but deactivate the LV before it completes
> - activate the LV
> 
> This is the point where the recovery should start back up, but it doesn't. I haven't tried this in a few weeks, but am happy to try it again if it would help.

Confirmed (test output below).  I'll get started on this.  This code can be a bit tricky and I've been away from it for a while.  It will take me a bit to re-familiarize myself with it and review your patch.

thanks,
 brassow


[root at bp-02 ~]# lvs -a -o name,attr,size,sync_percent vg
  LV               Attr       LSize   Cpy%Sync
  raid1            Rwi-a-r--- 300.00g   100.00
  [raid1_rimage_0] iwi-aor--- 300.00g         
  [raid1_rimage_1] iwi-aor--- 300.00g         
  [raid1_rmeta_0]  ewi-aor---   4.00m         
  [raid1_rmeta_1]  ewi-aor---   4.00m         
[root at bp-02 ~]# off.sh sda
Turning off sda
[root at bp-02 ~]# dd if=/dev/zero of=/dev/vg/raid1 bs=4M count=10000
10000+0 records in
10000+0 records out
41943040000 bytes (42 GB) copied, 147.139 s, 285 MB/s
[root at bp-02 ~]# on.sh sda
Turning on sda
[root at bp-02 ~]# lvs -a -o name,attr,size,sync_percent vg
  LV               Attr       LSize   Cpy%Sync
  raid1            Rwi-a-r-r- 300.00g   100.00
  [raid1_rimage_0] iwi-aor-r- 300.00g         
  [raid1_rimage_1] iwi-aor--- 300.00g         
  [raid1_rmeta_0]  ewi-aor-r-   4.00m         
  [raid1_rmeta_1]  ewi-aor---   4.00m         
[root at bp-02 ~]# lvchange --refresh vg/raid1
[root at bp-02 ~]# lvs -a -o name,attr,size,sync_percent vg
  LV               Attr       LSize   Cpy%Sync
  raid1            Rwi-a-r--- 300.00g     0.00
  [raid1_rimage_0] Iwi-aor--- 300.00g         
  [raid1_rimage_1] iwi-aor--- 300.00g         
  [raid1_rmeta_0]  ewi-aor---   4.00m         
  [raid1_rmeta_1]  ewi-aor---   4.00m         
[root at bp-02 ~]# lvs -a -o name,attr,size,sync_percent vg
  LV               Attr       LSize   Cpy%Sync
  raid1            Rwi-a-r--- 300.00g     0.29
  [raid1_rimage_0] Iwi-aor--- 300.00g         
  [raid1_rimage_1] iwi-aor--- 300.00g         
  [raid1_rmeta_0]  ewi-aor---   4.00m         
  [raid1_rmeta_1]  ewi-aor---   4.00m         
[root at bp-02 ~]# lvchange -an vg
[root at bp-02 ~]# lvchange -ay vg; lvs -a -o name,attr,size,sync_percent vg
  LV               Attr       LSize   Cpy%Sync
  raid1            Rwi-a-r--- 300.00g   100.00
  [raid1_rimage_0] iwi-aor--- 300.00g         
  [raid1_rimage_1] iwi-aor--- 300.00g         
  [raid1_rmeta_0]  ewi-aor---   4.00m         
  [raid1_rmeta_1]  ewi-aor---   4.00m