[dm-devel] [PATCH] blk-lib: fix error reporting

Christoph Hellwig hch at infradead.org
Tue Jul 8 09:50:38 UTC 2014


> +	if (unlikely(err))
> +		ACCESS_ONCE(bb->error) = err;

I can't see a reason for the ACCESS_ONCE here.

Also the likely/unlikely annotations here smell like premature
optimization.

Otherwise looks good to me.




More information about the dm-devel mailing list