[dm-devel] [PATCH 4/5] libmultipath: Print line number for which parsing failed
Bart Van Assche
bvanassche at acm.org
Fri Jul 18 12:54:13 UTC 2014
Make it easier to figure out which line contains a syntax error
by printing the line number and the offending line itself.
Signed-off-by: Bart Van Assche <bvanassche at acm.org>
---
libmultipath/parser.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/libmultipath/parser.c b/libmultipath/parser.c
index b7bdfcc..d8673bc 100644
--- a/libmultipath/parser.c
+++ b/libmultipath/parser.c
@@ -460,7 +460,7 @@ int
process_stream(vector keywords)
{
int i;
- int r = 0;
+ int r = 0, t;
struct keyword *keyword;
char *str;
char *buf;
@@ -501,8 +501,13 @@ process_stream(vector keywords)
free_strvec(strvec);
goto out;
}
- if (keyword->handler)
- r += (*keyword->handler) (strvec);
+ if (keyword->handler) {
+ t = (*keyword->handler) (strvec);
+ r += t;
+ if (t)
+ condlog(1, "multipath.conf +%d parsing failed: %s",
+ line_nr, buf);
+ }
if (keyword->sub) {
kw_level++;
--
1.8.4.5
More information about the dm-devel
mailing list