[dm-devel] [PATCH] dm: check era->md is non-NULL before closing it

naota at elisp.net naota at elisp.net
Tue May 20 03:53:56 UTC 2014

In era_ctr(), era->md remain NULL until it's set after metadata_open().
On the other hand, era_destroy() assume era->md is non-NULL and it is
called by era_ctr() before initializing the value.

This patch just checks if era->md is non-NULL.

Signed-off-by: Naohiro Aota <naota at elisp.net>
 drivers/md/dm-era-target.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/md/dm-era-target.c b/drivers/md/dm-era-target.c
index 414dad4..ad913cd 100644
--- a/drivers/md/dm-era-target.c
+++ b/drivers/md/dm-era-target.c
@@ -1391,7 +1391,8 @@ static int era_is_congested(struct dm_target_callbacks *cb, int bdi_bits)
 static void era_destroy(struct era *era)
-	metadata_close(era->md);
+	if (era->md)
+		metadata_close(era->md);
 	if (era->wq)

More information about the dm-devel mailing list