[dm-devel] [PATCH v2] dm thin: return ENOSPC instead of EIO when error_if_no_space enabled
Mike Snitzer
snitzer at redhat.com
Fri May 23 20:52:38 UTC 2014
On Thu, May 22 2014 at 2:32pm -0400,
Mike Snitzer <snitzer at redhat.com> wrote:
> Update the DM thin provisioning target's allocation failure error to be
> consistent with commit a9d6ceb8 ("[SCSI] return ENOSPC on thin
> provisioning failure").
>
> The DM thin target now returns -ENOSPC rather than -EIO when
> block allocation fails due to the pool being out of data space (and
> the 'error_if_no_space' thin-pool feature is enabled).
>
> Signed-off-by: Mike Snitzer <snitzer at redhat.com>
> ---
> drivers/md/dm-bio-prison.c | 4 ++--
> drivers/md/dm-bio-prison.h | 2 +-
> drivers/md/dm-thin.c | 35 +++++++++++++++++++++++------------
> 3 files changed, 26 insertions(+), 15 deletions(-)
>
> v2: update other should_error_unserviceable_bio() callers and dm_cell_error()
Noticed a leak introduced with my v2, but I've now staged what could be
considered v3 in linux-next via linux-dm.git 'for-next' branch, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=5d7d20909130de87ae4bccee0c9e92105eb7c886
More information about the dm-devel
mailing list