[dm-devel] [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS

Chris Mason clm at fb.com
Wed Sep 17 13:49:20 UTC 2014



On 09/15/2014 03:30 AM, behanw at converseincode.com wrote:
> From: Vinícius Tinti <viniciustinti at gmail.com>
> 
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This is the original VLAIS struct.
> 
> struct {
> 	struct shash_desc shash;
> 	char ctx[crypto_shash_descsize(tfm)];
> } desc;
> 
> This patch instead allocates the appropriate amount of memory using a
> char array using the SHASH_DESC_ON_STACK macro.
> 
> The new code can be compiled with both gcc and clang.
> 
> Signed-off-by: Vinícius Tinti <viniciustinti at gmail.com>
> Reviewed-by: Jan-Simon Möller <dl9pf at gmx.de>
> Reviewed-by: Mark Charlebois <charlebm at gmail.com>
> Signed-off-by: Behan Webster <behanw at converseincode.com>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Herbert Xu <herbert at gondor.apana.org.au>

Acked-by: Chris Mason <clm at fb.com>

On the btrfs bits.  Thanks for the v3.

-chris




More information about the dm-devel mailing list