[dm-devel] thin_check doesn't use data space map to open data mapping tree

[M.H. Tsai]

Hi All,

I found two doubtful points in thin-provisioning-tools,
which might need your help to provide some opinions:

1. thin_check doesn't open metadata and data space maps.
   It uses the core space_map to open the mapping_tree,
   instead of the data space map. Is that legal?
   (Although block_time_ref_counter was never used during tree traversal)

2. Class mapping_tree_detail::ll_damage_visitor should not be used to
traverse
   a single_mapping_tree. This class was designed for two-level data
mapping tree,
   or the top-level data mapping tree (i.e., mapping_tree and dev_tree
types).
   It generates missing_devices while visiting a damage with
zero-length-path,
   which is not semantically suitable for single_mapping_tree.


Thanks,
Ming-Hung Tsai
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20150406/97bf553e/attachment.htm>