[dm-devel] [PATCH] dm: test return value for DM_MAPIO_SUBMITTED
Mikulas Patocka
mpatocka at redhat.com
Wed Jul 1 21:30:36 UTC 2015
In properly written code we should not assume that DM_MAPIO_SUBMITTED is
zero. We should test the return value for DM_MAPIO_SUBMITTED rather than
testing it for zero.
Signed-off-by: Mikulas Patocka <mpatocka at redhat.com>
---
drivers/md/dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-4.1/drivers/md/dm.c
===================================================================
--- linux-4.1.orig/drivers/md/dm.c 2015-06-29 19:38:06.000000000 +0200
+++ linux-4.1/drivers/md/dm.c 2015-06-29 19:38:33.000000000 +0200
@@ -1526,7 +1526,7 @@ static void __map_bio(struct dm_target_i
md = tio->io->md;
dec_pending(tio->io, r);
free_tio(md, tio);
- } else if (r) {
+ } else if (r != DM_MAPIO_SUBMITTED) {
DMWARN("unimplemented target map return value: %d", r);
BUG();
}
More information about the dm-devel
mailing list